Skip to content
This repository has been archived by the owner on Jan 21, 2024. It is now read-only.

chore: move @halo-dev/api-client package to console #854

Merged
merged 2 commits into from
Feb 17, 2023

Conversation

ruibaby
Copy link
Member

@ruibaby ruibaby commented Feb 14, 2023

What type of PR is this?

/kind improvement

What this PR does / why we need it:

https://github.com/halo-sigs/api-client 移动到 Console 的仓库进行管理。

Which issue(s) this PR fixes:

Fixes halo-dev/halo#3302

Special notes for your reviewer:

测试方式:

  1. 需要先 pnpm install && pnpm build:packages
  2. 测试开发环境(pnpm dev)和构建之后(pnpm build)是否能够正常使用。

Does this PR introduce a user-facing change?

None

@f2c-ci-robot f2c-ci-robot bot added release-note-none Denotes a PR that doesn't merit a release note. kind/improvement Categorizes issue or PR as related to a improvement. labels Feb 14, 2023
@vercel
Copy link

vercel bot commented Feb 14, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated
ui ✅ Ready (Inspect) Visit Preview 💬 Add your feedback Feb 16, 2023 at 4:07AM (UTC)

Copy link
Member

@guqing guqing left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
验证通过

@f2c-ci-robot f2c-ci-robot bot added the lgtm Indicates that a PR is ready to be merged. label Feb 15, 2023
@f2c-ci-robot f2c-ci-robot bot removed the lgtm Indicates that a PR is ready to be merged. label Feb 16, 2023
Copy link
Member

@JohnNiang JohnNiang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@f2c-ci-robot
Copy link

f2c-ci-robot bot commented Feb 17, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: JohnNiang

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@f2c-ci-robot f2c-ci-robot bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 17, 2023
@guqing
Copy link
Member

guqing commented Feb 17, 2023

/lgtm

@f2c-ci-robot f2c-ci-robot bot added the lgtm Indicates that a PR is ready to be merged. label Feb 17, 2023
@f2c-ci-robot f2c-ci-robot bot merged commit b949a25 into halo-dev:main Feb 17, 2023
@ruibaby ruibaby deleted the chore/api-client branch February 17, 2023 06:31
@ruibaby ruibaby modified the milestones: 2.3.x, 2.3.0 Feb 20, 2023
JohnNiang pushed a commit to JohnNiang/halo that referenced this pull request Mar 2, 2023
…#854)

#### What type of PR is this?

/kind improvement

#### What this PR does / why we need it:

将 https://github.com/halo-sigs/api-client 移动到 Console 的仓库进行管理。

#### Which issue(s) this PR fixes:

Fixes halo-dev#3302

#### Special notes for your reviewer:

测试方式:

1. 需要先 `pnpm install && pnpm build:packages`
2. 测试开发环境(pnpm dev)和构建之后(pnpm build)是否能够正常使用。

#### Does this PR introduce a user-facing change?

```release-note
None
```
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/improvement Categorizes issue or PR as related to a improvement. lgtm Indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesn't merit a release note.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

将 halo-sigs/api-client 包放在 Console 仓库管理
3 participants